On Mon, 10 Nov 2014, Pablo Neira Ayuso wrote:
> On Mon, Nov 10, 2014 at 03:27:51PM +0100, Jozsef Kadlecsik wrote:
> > On Mon, 10 Nov 2014, Pablo Neira Ayuso wrote:
> > > >From other similar code in that location, I can see Jozsef is using
> > > this pattern:
> > >
> > > if (*len != sizeof(struct ip_set_req_version)) {
> > > ret = -EINVAL;
> > > goto done;
> > > }
> > >
> > > I think it would be good to stick to that for consistency. Thanks.
> >
> > Absolutely, yes.
> >
> > Acked-by: Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxxxxxx>
>
> OK, then does this look fine to you? I took over Dan's patch and gave
> it another spin. See it attached, thanks.
Yes, it's better this way, thanks!
Best regards,
Jozsef
-
E-mail : kadlec@xxxxxxxxxxxxxxxxx, kadlecsik.jozsef@xxxxxxxxxxxxx
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
H-1525 Budapest 114, POB. 49, Hungary
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
