On Thursday 2014-11-06 19:25, Pablo Neira Ayuso wrote:
>+AM_CPPFLAGS += -DDEFAULT_INCLUDE_PATH="\"${sysconfdir}\"" -D__USE_GNU
feature_test_macros(7) specifies _GNU_SOURCE rather than __USE_GNU.
>+AM_CFLAGS = -Wall \
>+ -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations \
>+ -Wdeclaration-after-statement -Wsign-compare -Winit-self \
>+ -Wformat-nonliteral -Wformat-security -Wmissing-format-attribute \
>+ -Wcast-align -Wundef -Wbad-function-cast # -Wshadow \
>+ -Waggregate-return -Wunused -Wwrite-strings \
>+ ${LIBMNL_CFLAGS} ${LIBNFTNL_CFLAGS}
You have a # in there, which causes the remaining -W and -I from
LIBMNL_CFLAGS to be absent from the compilation line.
LIBMNL_CFLAGS and LIBNFTNL_CFLAGS should be in AM_CPPFLAGS because
they are, well, cppflags. (It's a pkgconfig "bug").
This was properly done in the original autotools submissions.
>--- /dev/null
>+++ b/m4/.gitignore
>@@ -0,0 +1,2 @@
>+*
>+!.gitignore
The last entry is not needed, because .gitignore would already be
unignored because it is tracked.
/lt*.m4
/libtool.m4
as in the original submission would ensure that no more files are
ignored than absolutely necessary, so as to be aware of potential
additional files popping up.
>--- a/src/scanner.l
>+++ b/src/scanner.l
>@@ -169,6 +169,7 @@ ip6addr ({v680}|{v67}|{v66}|{v65}|{v64}|{v63}|{v62}|{v61}|{v60})
> addrstring ({macaddr}|{ip4addr}|{ip6addr})
>
> %option prefix="nft_"
>+%option outfile="lex.yy.c"
> %option reentrant
> %option noyywrap
> %option nounput
Why is this needed? The default output filename is already lex.yy.c
(and ylwrap will rename it anyway).
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
