On Thu, 2014-11-06 at 00:23 +0100, Pablo Neira Ayuso wrote: > On Wed, Nov 05, 2014 at 02:24:29PM -0500, Steven Rostedt wrote: > > From: Joe Perches <joe@xxxxxxxxxxx> > > > > Since adding a new function to seq_file (seq_has_overflowed()) > > there isn't any value for functions called from seq_show to > > return anything. Remove the int returns of the various > > print_tuple/<foo>_print_tuple functions. [] > I replied to this yesterday, but it seems some spam filter also > munched it. One comment below. > > > @@ -202,9 +203,8 @@ static int ct_seq_show(struct seq_file *s, void *v) > > if (l4proto->print_conntrack) > > l4proto->print_conntrack(s, ct); > > > > - if (print_tuple(s, &ct->tuplehash[IP_CT_DIR_ORIGINAL].tuple, > > - l3proto, l4proto)) > > - goto release; > > + print_tuple(s, &ct->tuplehash[IP_CT_DIR_ORIGINAL].tuple, > > + l3proto, l4proto); > > > > if (seq_print_acct(s, ct, IP_CT_DIR_ORIGINAL)) > > goto release; > > seq_print_acct returns seq_printf which is now void. I guess you have > to remove this check too. seq_printf shouldn't be void yet. There are still other places that need conversion. > > if (seq_print_acct(s, ct, IP_CT_DIR_REPLY)) > > goto release; > > And here. Eventually I trust it will be fixed, but these patches are an intermediate step on the way there. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
