Re: [PATCH] netfilter: bridge: unshare bridge info before change it

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 04, 2014 at 08:45:09AM +0800, Gao feng wrote:
> On 09/29/2014 03:35 PM, Gao feng wrote:
> > Many packets may share the same bridge information,
> > we should unshare the bridge info before we change it,
> > otherwise other packets will go to PF_INET(6)/PRE_ROUTING
> > second time or the pkt_type of other packets will be
> > incorrect.
> > 
> > The problem occurs when we do nfqueue after br_nf_pre_routing
> > and before bf_nf_pre_routing_finish, if the packet is gso,
> > the new segs will share the same bridge info. and netfilter
> > may use skb_clone, this will cause many packets share the
> > same bridge info too.
> > 
> > Signed-off-by: Gao feng <gaofeng@xxxxxxxxxxxxxx>
> > ---
> 
> any comments?

This doesn't apply cleanly. We modularized br_netfilter by the time
you sent this, see 54dc125. You'll have to rebase this patch.

Moreover, could you develop what you're noticing a bit more? Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux