On Sun, 26 Oct 2014, Thomas Graf wrote: > On 10/26/14 at 06:12pm, Jozsef Kadlecsik wrote: > > > > According to my tests the slowdown in ipset (netlink) is caused by the > > patch: > > > > commit e341694e3eb57fcda9f1adc7bfea42fe080d8d7a > > Author: Thomas Graf <tgraf@xxxxxxx> > > Date: Sat Aug 2 11:47:45 2014 +0200 > > > > netlink: Convert netlink_lookup() to use RCU protected hash table > > > > Running the test provided in the report below in a KVM guest, the times > > spent in adding ~430 entries, saving, then restoring those > > Thanks for tracking this down. I would assume that the following fix > addresses the ipset regression as well: > > commit 78fd1d0ab072d4d9b5f0b7c14a1516665170b565 > Author: Thomas Graf <tgraf@xxxxxxx> > Date: Tue Oct 21 22:05:38 2014 +0200 > > netlink: Re-add locking to netlink_lookup() and seq walker > > The synchronize_rcu() in netlink_release() introduces unacceptable > latency. Reintroduce minimal lookup so we can drop the > synchronize_rcu() until socket destruction has been RCUfied. > > Cc: David S. Miller <davem@xxxxxxxxxxxxx> > Cc: Eric Dumazet <eric.dumazet@xxxxxxxxx> > Reported-by: Steinar H. Gunderson <sgunderson@xxxxxxxxxxx> > Reported-and-tested-by: Heiko Carstens <heiko.carstens@xxxxxxxxxx> > Signed-off-by: Thomas Graf <tgraf@xxxxxxx> > Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx> I'm going to test it tomorrow and report back to you the results. Thanks for the fast reply! Best regards, Jozsef - E-mail : kadlec@xxxxxxxxxxxxxxxxx, kadlecsik.jozsef@xxxxxxxxxxxxx PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences H-1525 Budapest 114, POB. 49, Hungary -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
