On Thu, Oct 02, 2014 at 01:58:42PM +0200, Arturo Borrero Gonzalez wrote: > The masq expression is lacking of tests. Let's add some. Applied, thanks. Please, make sure git am doesn't complain with trailing whitespace and empty lines at the end of the file. git am reported two in this patch. > diff --git a/tests/jsonfiles/68-rule-masq.json b/tests/jsonfiles/68-rule-masq.json > new file mode 100644 > index 0000000..cfaed4c > --- /dev/null > +++ b/tests/jsonfiles/68-rule-masq.json > @@ -0,0 +1,2 @@ > +{"nftables":[{"rule":{"family":"ip6","table":"nat","chain":"postrouting","handle":4,"expr":[{"type":"masq","flags":12}]}}]} > + Here. > +++ b/tests/xmlfiles/79-rule-masq.xml ^^ BTW, I wonder when the file numbering diverted (in xml, this 79 but in json this is 68), it seems we have more tests for XML than json. For similar mirror tests, we should be using the same number. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html