On Mon, Sep 22, 2014 at 11:05:58AM +0200, Álvaro Neira Ayuso wrote: > El 22/09/14 09:59, Patrick McHardy escribió: > >On Sun, Sep 21, 2014 at 09:32:36PM +0200, Alvaro Neira Ayuso wrote: > >>This function finds the symbol inside the table that you pass as parameter. > >>If the symbol doesn't exist we use the basetype to parse it and > >>symbolic_constant_parse(). > > > >I'm thinking that we should probably do this in all cases and not > >specific to mark and ICMP types. At least I can't see a reason not > >to. > > > > Sorry Patrick, I don't understand your answer. Could you elaborate that? > Looks good for you? > No, I'm suggesting to not add some new function for specific cases but always fall back to parsing in the base type. tcp flags 0x3 mark 0x1 ct state 4 and so on. Basically what we're doing for mark now, just for everything, I don't see a reason not do to this. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
