Re: [PATCH 03/22] netfilter: Replace strnicmp with strncasecmp

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 17 2014, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:

> On Tue, Sep 16, 2014 at 10:51:17PM +0200, Rasmus Villemoes wrote:
>> The kernel used to contain two functions for length-delimited,
>> case-insensitive string comparison, strnicmp with correct semantics
>> and a slightly buggy strncasecmp. The latter is the POSIX name, so
>> strnicmp was renamed to strncasecmp, and strnicmp made into a wrapper
>> for the new strncasecmp to avoid breaking existing users.
>> 
>> To allow the compat wrapper strnicmp to be removed at some point in
>> the future, and to avoid the extra indirection cost, do
>> s/strnicmp/strncasecmp/g.
>
> I don't manage to find the strnicmp wrapper patch:
>
> http://thread.gmane.org/gmane.linux.kernel/1775150/focus=1775152
>
> perhaps I'm looking at the wrong tree? Please clarify. Thanks.

It's in mmots,
<http://git.cmpxchg.org/cgit.cgi/linux-mmots.git/commit/?id=7acc5207bcc2fbf0929bd3ee14c414b9defa3382>.
I thought it had made it to linux-next, but failed to check that. Andrew
said he'd take that patch as well as the treewide follow-up patches, to
ensure they'd be applied in the right order.

Sorry for the confusion,
Rasmus
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux