Re: [PATCH] parser: simplify monitor command parsing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 17, 2014 at 09:52:11AM +0200, Arturo Borrero Gonzalez wrote:
> On 17 September 2014 09:45, Patrick McHardy <kaber@xxxxxxxxx> wrote:
> > Add tokens for "new" and "destroy". Split up the monitor flags into an
> > event and an object to avoid lots of duplicated code.
> >
> > Signed-off-by: Patrick McHardy <kaber@xxxxxxxxx>
> > ---
> 
> I think the 'new' keyword may clash with 'ct new', don't you?. That's
> why Pablo did the parser that way.

Right. The split into event and object still saves a lot of code, I'll
add back the strcmp if I can't think of a nicer way to fix this.

I'm working on command line completion based on the bison grammar, so
I'd prefer to only use strings for identifiers, not for keywords.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux