On 09/02/14 at 02:22pm, Pablo Neira Ayuso wrote: > On Tue, Sep 02, 2014 at 11:59:22AM +0100, Patrick McHardy wrote: > > > The anonymous sets are problematic, we need to notify this from the > > > commit path too to ensure the right ordering. I was trying to avoid > > > some specific notify() interface in expr->ops but it seems we need it > > > for nft_lookup.c. > > > > > > Can you think of a better solution? > > > > No, unless we can come up with a way that's synchronous. > > I would really like not to go back to the two nearly consecutive > synchronize_rcu() calls, it's slow. I've been thinking on replacing > the current check in the packet path by static keys, but I didn't > manage to find the way yet. Slight warning on additional complexity down the road: I'm about to propose a rhashtable enhancement to move expansion/shrinking to a async worker thread and protect insertion/removal by an array of spinlocks. It will allow for much faster parallel inclusion/removal but will require a sync on destruction to cancel/wait for any outstanding/ongoing maintenance on the hash table. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
