On Mon, Aug 04, 2014 at 06:00:08PM +0200, Alvaro Neira Ayuso wrote: > Currently, we suppose that all the dependency are in host endian. The problem > is if we try to add a dependency with big endian byteorder, we create > this dependency wrong. For example, if we add a ether type dependency in bridge, > we must use big endian byteorder and we use host endian and we create wrong the > payload. > > Now, we are going to create the dependency taking account the byteorder. This seems correct to me. > > Signed-off-by: Alvaro Neira Ayuso <alvaroneay@xxxxxxxxx> > --- > src/payload.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/payload.c b/src/payload.c > index be3d610..8b10a79 100644 > --- a/src/payload.c > +++ b/src/payload.c > @@ -213,8 +213,7 @@ int payload_gen_dependency(struct eval_ctx *ctx, const struct expr *expr, > left = payload_expr_alloc(&expr->location, desc, desc->protocol_key); > > right = constant_expr_alloc(&expr->location, tmpl->dtype, > - BYTEORDER_HOST_ENDIAN, > - tmpl->len, > + tmpl->dtype->byteorder, tmpl->len, > constant_data_ptr(protocol, tmpl->len)); > > dep = relational_expr_alloc(&expr->location, OP_EQ, left, right); > -- > 1.7.10.4 > -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
