Re: [PATCH] nftables: Avoid duplicate call to nft_data_uninit() for same key

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 01, 2014 at 05:25:38PM +0200, Thomas Graf wrote:
> nft_del_setelem() currently calls nft_data_uninit() twice on the same
> key. Once to release the key which is guaranteed to be NFT_DATA_VALUE
> and a second time in the error path to which it falls through.
> 
> The second call has been harmless so far though because the type
> passed is always NFT_DATA_VALUE which is currently a no-op.

Applied, thanks Thomas.

BTW, this bug seems to be there since the very beginning:
http://lxr.free-electrons.com/source/net/netfilter/nf_tables_api.c?v=3.13#L2735
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux