On 1. August 2014 14:49:01 GMT+01:00, Thomas Graf <tgraf@xxxxxxx> wrote: >On 08/01/14 at 02:21pm, Nikolay Aleksandrov wrote: >> Sorry for the late response but I just got around to check the 3rd >patch now, >> so my question about this fragment is: before nft_hash_remove() would >free the >> element after removal, but after this change I don't see where and >when the >> removed element would get freed ? > >You are right. Looking at this closer we were leaking references even >before the change because it would not call nft_data_uninit() to >release >the data objects. So it should really just call >nft_hash_elem_destroy(). No, the data uninit is performed by the set core. Just freeing it is fine. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
