Re: [PATCH nf-next] netfilter: don't use mutex_lock_interruptible()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



	Hello,

On Thu, 31 Jul 2014, Pablo Neira Ayuso wrote:

> Eric Dumazet reports that getsockopt() or setsockopt() sometimes
> returns -EINTR instead of -ENOPROTOOPT, causing headaches to
> application developers.
> 
> This patch replaces all the mutex_lock_interruptible() by mutex_lock()
> in the netfilter tree, as there is no reason we should sleep for a
> long time there.
> 
> Reported-by: Eric Dumazet <edumazet@xxxxxxxxxx>
> Suggested-by: Patrick McHardy <kaber@xxxxxxxxx>
> Signed-off-by: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
> ---

	IPVS part looks ok, here is ack if needed:

Acked-by: Julian Anastasov <ja@xxxxxx>

>  net/bridge/netfilter/ebtables.c |   10 ++-------
>  net/netfilter/core.c            |   11 ++-------
>  net/netfilter/ipvs/ip_vs_ctl.c  |   19 ++++------------
>  net/netfilter/nf_sockopt.c      |    8 ++-----
>  net/netfilter/x_tables.c        |   47 ++++++++++-----------------------------
>  5 files changed, 22 insertions(+), 73 deletions(-)

Regards

--
Julian Anastasov <ja@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux