Re: [PATCH nf-next] netfilter: xt_hashlimit: perform garbage collection from process context

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 24, 2014 at 10:27:44AM +0200, Florian Westphal wrote:
> Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote:
> > From: Eric Dumazet <edumazet@xxxxxxxxxx>
> > 
> > xt_hashlimit cannot be used with large hash tables, because garbage
> > collector is run from a timer. If table is really big, its possible
> > to hold cpu for more than 500 msec, which is unacceptable.
> > 
> > Switch to a work queue, and use proper scheduling points to remove
> > latencies spikes.
> > 
> > Later, we also could switch to a smoother garbage collection done
> > at lookup time, one bucket at a time...
> > 
> > Signed-off-by: Eric Dumazet <edumazet@xxxxxxxxxx>
> 
> Reviewed-by: Florian Westphal <fw@xxxxxxxxx>

Applied, thanks Eric!
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux