On Thursday 2014-07-10 16:54, Pablo Neira Ayuso wrote: >On Thu, Jul 10, 2014 at 04:08:08PM +0200, Giorgio Dal Molin wrote: >> Added an #include <config.h> to all the C source files so that the results >> of the tests in the configure script are available to all the compilation >> units. > >I think we can avoid this by passing the configuration options to the >compiler via -D instead of via config.h file. > >https://www.gnu.org/software/autoconf/manual/autoconf-2.65/html_node/Configuration-Headers.html > >Any reason not to do it that way? The compiler command line is already long enough (when choosing to look at it via `make V=1`) for human analysis, and distros easily add even more CFLAGS like -O,-f,-m into it. Not using config.h would make the situation worse for analysis by human. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
