----- Original Nachricht ---- Von: Patrick McHardy <kaber@xxxxxxxxx> An: Giorgio Dal Molin <giorgio.nicole@xxxxxxxx> Datum: 10.07.2014 12:04 Betreff: Re: [PATCH 4/7] autotools conversion: include the header 'config.h' in every C source file. > On Mon, Jul 07, 2014 at 04:19:28PM +0200, Giorgio Dal Molin wrote: > > Added an #include <config.h> to all the C source files so that the > results > > of the tests in the configure script are available to all the compilation > > units. > > > > We could have added the include also to 'yacc_parser.y' and 'scanner.l' > > but we don't, because it is not strictly needed and to avoid to define > > the variable 'VERSION' two times. > > > --- a/src/cli.c > > +++ b/src/cli.c > > @@ -11,6 +11,9 @@ > > * > > * Development of this code funded by Astaro AG (http://www.astaro.com/) > > */ > > +#ifdef HAVE_CONFIG_H > > +#include <config.h> > > +#endif > > Do we really need those ifdefs? > Hi, do you mean just the #ifdefs or the whole #include <config.h> ? The config.h should be included, unless there are real problems with it; one I've found is the preprocessor variable VERSION defined in the yacc source 'src/yacc_parser.y': it would conflict with the same variable defined in the 'config.h'. Actually, if you just build the package under linux, using the ./configure... && make all install you will always generate / include the config.h, so the #ifdef is not strictly needed. giorgio -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
