On Monday 2014-07-07 12:16, Giorgio Dal Molin wrote:
>- AC_MSG_ERROR([No suitable version of libnftnl found]))
>+dnl Check for package libnftnl
>+PKG_CHECK_MODULES(LIBMNL, [libmnl], , AC_MSG_ERROR([No suitable version of libmnl found]))
>+AC_SUBST(LIBMNL_CFLAGS)
>+AC_SUBST(LIBMNL_LIBS)
Substing CFLAGS and LIBS is not needed; this is already included
in PKG_CHECK_MODULES.
>--- /dev/null
>+++ b/src/Makefile.am
>@@ -0,0 +1,45 @@
>+sbin_PROGRAMS = nft
>+
>+nft_CFLAGS = -fno-strict-aliasing \
>+ -Wall \
>+ -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations \
>+ -Wdeclaration-after-statement -Wsign-compare -Winit-self \
>+ -Wformat-nonliteral -Wformat-security -Wmissing-format-attribute \
>+ -Wcast-align -Wundef -Wbad-function-cast \
>+ -Waggregate-return -Wunused -Wwrite-strings \
>+ @LIBMNL_CFLAGS@ @LIBNFTNL_CFLAGS@
>+
>+nft_CPPFLAGS = -I${srcdir}/../include @DEBUG_CPPFLAGS@
As the pkg-config CFLAGS are really just CPPFLAGS, @LIBMNL_CFLAGS@
and @LIBNFTNL_CFLAGS@ should be put into nft_CPPFLAGS instead. In
fact, you can just use ${LIBMNL_CFLAGS} and ${LIBNFTNL_CFLAGS} (same
for _LIBS) instead, which ensures that you can override them at make
time. Also, if nft_CPPFLAGS is not strictly necessary, use
AM_CPPFLAGS (and AM_CFLAGS) instead.
See also the autotooling I had done earlier
and which you and me have talked about ;)
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
