Joern Heissler <nfdevel@xxxxxxxxxxxxxxxxx> wrote:
> Hi,
>
> I'm trying to use libnetfilter_log and I think I might have found a bug :)
Looks like nfnl_handle_packet doesn't handle control messages (like NLMSG_DONE).
I don't understand libnfnetlink here, specifically why
nfnl_handle_packet exists in first place, seems like it was superseded
by nfnl_process(), so I *thought* a quick fix is
--- a/src/libnetfilter_log.c
+++ b/src/libnetfilter_log.c
@@ -322,7 +322,7 @@ int nflog_callback_register(struct nflog_g_handle *gh, nflog_callback *cb,
int nflog_handle_packet(struct nflog_handle *h, char *buf, int len)
{
- return nfnl_handle_packet(h->nfnlh, buf, len);
+ return nfnl_process(h->nfnlh, (unsigned char *) buf, len);
}
But that breaks probably every user of the library since
nfnl_process() expects cb to return NFNL_CB_CONTINUE (== 1)
and not 0 (which makes _process top iterating).
But 0 is what the examples use :-(
'someone' has to touch libnfnetlink it seems...
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
