On Wed, Jun 25, 2014 at 02:32:43PM +0200, Pablo Neira Ayuso wrote: > + switch (li->type) { > + case NF_LOG_TYPE_LOG: > + if (tb[NFTA_LOG_SYSLOG] != NULL) { > + li->u.log.level = > + ntohl(nla_get_be32(tb[NFTA_LOG_SYSLOG]));; > + } else { > + li->u.log.level = 4; > + } I'd suggest to call it what it is, NFTA_LOG_LEVEL. Besides this minor issue, the patches look good to me. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html