On Sun, Jun 08, 2014 at 11:41:23AM +0200, Florian Westphal wrote:
> 'last' keeps track of the ct that had its refcnt bumped during previous
> dump cycle. Thus it must not be overwritten until end-of-function.
>
> Another (unrelated, theoretical) issue: Don't attempt to bump refcnt of a conntrack
> whose reference count is already 0. Such conntrack is being destroyed
> right now, its memory is freed once we release the percpu dying spinlock.
>
> Fixes: b7779d06 ('netfilter: conntrack: spinlock per cpu to protect special lists.')
> Signed-off-by: Florian Westphal <fw@xxxxxxxxx>
> ---
> With this patch I do not see any more stale entries on the dying list with eache evictor
> not being scheduled. Such 'leaked' entries are easy to spot since their 'use' count
> is growing, i.e. invoking conntrack -L dying repeatedly yields 'use=$bignum++' output.
Applied, thanks Florian!
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
