On 13 June 2014 11:31, Ana Rey <anarey@xxxxxxxxx> wrote:
[...]
> diff --git a/src/expr/queue.c b/src/expr/queue.c
> index 9f269e7..5dad84a 100644
> --- a/src/expr/queue.c
> +++ b/src/expr/queue.c
> @@ -194,46 +194,66 @@ nft_rule_expr_queue_xml_parse(struct nft_rule_expr *e, mxml_node_t *tree,
> #endif
> }
>
> -static int
> -nft_rule_expr_queue_snprintf(char *buf, size_t len, uint32_t type,
> - uint32_t flags, struct nft_rule_expr *e)
> +static int nft_rule_expr_queue_snprintf_default(char *buf, size_t len,
> + struct nft_rule_expr *e)
As I see this in my email client, It seems that this is not correctly
aligned. But I don't really know, as I'm reviewing without pushing the
patch to my stack.
> {
> struct nft_expr_queue *queue = nft_expr_data(e);
> int ret;
> int one = 0;
>
> + ret = snprintf(buf, len, "num %u total %u", queue->queuenum,
> + queue->queues_total);
> + if (queue->flags) {
> + ret += snprintf(buf + ret, len - ret, " options ");
> + if (queue->flags & NFT_QUEUE_FLAG_BYPASS) {
> + ret += snprintf(buf + ret, len - ret, "bypass");
> + one = 1;
> + }
> + if (queue->flags & NFT_QUEUE_FLAG_CPU_FANOUT) {
> + if (one)
> + ret += snprintf(buf + ret, len - ret, ",");
> + ret += snprintf(buf + ret, len - ret, "fanout");
> + }
> + }
> + return ret;
> +}
I would recommend to use the SNPRINTF_BUFFER_SIZE macro, so we keep
this consistent with all the other code.
regards
--
Arturo Borrero González
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
