Re: [RFC PATCH 1/1 libnetfilter_conntrack] zero value handling of mark and zone

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 12, 2014 at 01:59:25PM +0200, Florian Westphal wrote:
> > > ct1 and ct2 zones would then always be equal except if
> > > both have ATTR_ZONE set and the zones are different.
> > 
> > I think it reasonable too, but attr holds old value if it was unset.
> 
> Yes, but nfct_get_attr_u* return 0 if attribute bit is unset.

That's why you do not use the raw value. I should have understood
it earlyer, sorry.

> So I think this should work.

I agree with you, thank you.
Should we clear errno in that cmp_zone() before return?
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux