Re: [PATCH iptables] libxtables: fix getaddrinfo return value usage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 11, 2014 at 10:48:19AM +0100, Domen Puncer wrote:
> On 11/06/14 10:37, Pablo Neira Ayuso wrote:
> > On Tue, Jun 10, 2014 at 02:29:49PM +0100, Domen Puncer wrote:
> >> getaddrinfo return value on error can also be positive.
> > 
> > At quick glance, all EAI_* that I see are negative.
> 
> You don't see all of them :-)
> On Android they're positive, e.g.:
> 	android-ndk-r9d/platforms/android-19/arch-arm/usr/include/netdb.h
> 	147 #define EAI_NONAME       8      /* hostname nor servname provided,
> or not known */

I suspected something like this..

Please, next time include this in the patch description since the
beginning, thanks.

> And as a plus, it's not bad to conform to specs.

It sounds like a reasonable assumption to me.

Do you have more patches like this in your queue?
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux