On Wed, Jun 11, 2014 at 06:14:40PM +0200, Arturo Borrero Gonzalez wrote:
> Hi Ana,
>
> a small thing below,
>
> On 11 June 2014 17:50, Ana Rey <anarey@xxxxxxxxx> wrote:
> [...]
> > @@ -563,17 +560,26 @@ static int nft_set_elem_snprintf_xml(char *buf, size_t size,
> > {
> > int ret, len = size, offset = 0, type = DATA_NONE;
> >
> > - ret = snprintf(buf, size, "<set_elem>"
> > - "<flags>%u</flags><key>",
> > - e->set_elem_flags);
> > + ret = snprintf(buf, size, "<set_elem>");
> > SNPRINTF_BUFFER_SIZE(ret, size, len, offset);
> >
> > - ret = nft_data_reg_snprintf(buf+offset, len, &e->key,
> > - NFT_OUTPUT_XML, flags, DATA_VALUE);
> > - SNPRINTF_BUFFER_SIZE(ret, size, len, offset);
> > + if (e->flags & (1 << NFT_SET_ELEM_ATTR_FLAGS)) {
> > + ret = snprintf(buf, size, "<flags>%u</flags>",
> > + e->set_elem_flags);
>
> I think this snprintf call may overwrite the buffer, so you should use
> snprintf(buf+offset, len, ...)
Thanks for reviewing Arturo.
I have fixed this here and applied.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
