Yuxuan Shui <yshuiv7@xxxxxxxxx> wrote: + case NFT_META_SKPID: > + if (skb->sk == NULL || skb->sk->sk_state == TCP_TIME_WAIT) > + goto err; > + > + read_lock_bh(&skb->sk->sk_callback_lock); > + dest->data[0] = pid_nr(skb->sk->sk_peer_pid); > + read_unlock_bh(&skb->sk->sk_callback_lock); > + break; > + case NFT_META_SKSID: > + if (skb->sk == NULL || skb->sk->sk_state == TCP_TIME_WAIT) > + goto err; > + > + read_lock_bh(&skb->sk->sk_callback_lock); > + task = get_pid_task(skb->sk->sk_peer_pid, PIDTYPE_PID); > + sid = task_session(task); > + if (!sid) looks like you need to unlock here. > + goto err; -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html