From: David Newall <davidn@xxxxxxxxxxxxxxx> Date: Fri, 30 May 2014 18:47:58 +0930 > On 30/05/14 08:04, David Miller wrote: >> You really need to check the return value as this can perform >> allocations, >> GFP_ATOMIC ones in fact. >> >> Also, why are we not bumping the statistics any more? I didn't see a >> discussion of that in this thread. > > I was only restoring the code as it was before the commit. Maybe > this, (instead of the previous patch of br_netfilter.c,) to keep the > (added) check on pskb_may_pull's return value and incremented > statistics? I don't see why you don't simply keep br_parse_ip_options() around and adjust it as you need, you're just mostly duplicating it's contents into br_nf_pre_routing(). -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
