On Mon, May 12, 2014 at 04:56:57PM +0400, Vasily Averin wrote:
>
> Signed-off-by: Vasily Averin <vvs@xxxxxxxxxx>
> ---
> net/bridge/br_netfilter.c | 12 ++++++++++++
> 1 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/net/bridge/br_netfilter.c b/net/bridge/br_netfilter.c
> index 2acf7fa..3e81fd6 100644
> --- a/net/bridge/br_netfilter.c
> +++ b/net/bridge/br_netfilter.c
> @@ -64,6 +64,18 @@ static int brnf_pass_vlan_indev __read_mostly = 0;
> #define brnf_pass_vlan_indev 0
> #endif
>
> +#ifdef CONFIG_SYSCTL
> +static struct brnf_net init_brnf_net = {
> + .hdr = NULL,
> + .call_arptables = brnf_call_arptables,
> + .call_iptables = brnf_call_iptables,
> + .call_ip6tables = brnf_call_ip6tables,
> + .filter_vlan_tagged = brnf_filter_vlan_tagged,
> + .filter_pppoe_tagged = brnf_filter_pppoe_tagged,
> + .pass_vlan_indev = brnf_pass_vlan_indev,
> +};
> +#endif
These patches are split in an unnecessary excessive fashion and are hard
to review. The rule is one patch per logical change, not one patch per
file. Introducing a structure and not using it might be acceptable, but
adding a structure definition and not using it is just stupid.
Also introducing all these init_brnf_net conversion that are completely
replaced afterwards is just useless noise. Please combine them in a more
reasonable fashion and resend.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
