Patrick McHardy <kaber@xxxxxxxxx> wrote: > Before the upcoming release, I'd like to add some more consistency among > nftables data type names. We currently have the following types: [..] > In some cases we're more verbose, in other we're using abrevations. > I'd like to decide for either one. > > The following ones should IMO definitely be changed: > > - etheraddr => ether_address or mac_address. ether_addr would be more > consistent with ethertype. > > - ethertype => ether_type if ether_addr is used I like ether_type/ether_addr. > - optionally: *_address => *_addr We already have 'ip saddr/daddr' etc in nft rules, so I'd prefer to use _addr everywhere. > - arphrd => iftype/interface_type? I read that as "arphdr"... Since its used of iif/oiftype I think interface_type is good choice. > If we're deciding for more verbose names (which IMO is fine for types), > I'd also change: > > - arp_op => arp_operation > - ifindex => interface_index > - nfproto => nf_protocol I agree iff we go for eg. _address instead of _addr. I would prefer _addr, i.e. > otherwise: > > - inet_protocol => inet_proto inet_proto, too. Looking at scanner.l we also have l3proto, l4proto, nfproto keywords. [ I realize that there is not requirement to be consistent with datatype names vs. nft rules but I see no reason to differ ] > Basically the should be human readable, not programmer readable, should > describe what they actually are (not arphrd) and should be consistent. Fully agree, more consistency would be good. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
