Re: [libnftnl PATCH 1/3] ruleset: Add an end of line in the exit of ruleset.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9 April 2014 10:53, Ana Rey <anarey@xxxxxxxxx> wrote:
> Add an end of line in the exit of ruleset.
>
> Signed-off-by: Ana Rey <anarey@xxxxxxxxx>

Hi Ana,

Why do you need this here?

The policy was to don't add any format stuff (tabs, newlines..) to
XML|JSON formats and let the caller add the trailing \n if needed..

However, I see several inconsistencies already in the code:
src/rule.c: ret = snprintf(buf+offset, len, "\n");
src/rule.c: ret = snprintf(buf+offset, len, "]\n");
src/rule.c: ret = snprintf(buf+offset, len, " }\n");
src/set.c: ret = snprintf(buf+offset, len, "\n");

-- 
Arturo Borrero González
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux