On Tue, Apr 08, 2014 at 11:20:35AM +0300, Tomasz Bursztyka wrote: > Hi Pablo, > > >Please, also rework this so we have one _init function for the get and > >the set variants, ie. nft_meta_bridge_get_init and > >nft_meta_bridge_set_init, I'd suggest. > > > >Apart from that, this patch looks fine to me. Thanks. > > I fully changed that on the version 2. This RFC is no longer valid, prior to > Patrick's comments and also his changes on nft_meta.c Right, I looked at the wrong patchset, sorry. In http://patchwork.ozlabs.org/patch/336891/, I can still see there this chunk though. +static void nft_meta_bridge_get_eval(const struct nft_expr *expr, + struct nft_data data[NFT_REG_MAX + 1], + const struct nft_pktinfo *pkt) +{ + const struct nft_meta *priv = nft_expr_priv(expr); + const struct net_device *in = pkt->in, *out = pkt->out; + struct nft_data *dest = &data[priv->dreg]; + const struct net_bridge_port *p; + + if (pkt->ops->pf != NFPROTO_BRIDGE) Do you really need this or is it just defensive? -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
