Re: [nftables PATCH] src: rule: Fix list of set: Add a forgotten 'return'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 08, 2014 at 09:19:27AM +0200, Ana Rey wrote:
> Add a return forgotten.

I prefer if you include in the patch description the important facts:

* This patch fixes a crash since this iterates over the temporary
  context list a bit below on that code to handle table and chains
  (that we don't have in this case).

* Something descriptive on how this happens, eg.

  % nft list sets
  Segmentation fault

Or even better:

  % valgrind nft list sets
  ...
  valgrind report goes here.
  ...

Please, also rework the title:

src: rule: Fix list of set: Add a forgotten 'return'

something much more simple like:

rule: fix crash in set listing

should be fine.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux