Re: [PATCH nft] expr: do not suppress OP_EQ when RHS is bitmask type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
> On Mon, Mar 17, 2014 at 11:08:38PM +0100, Florian Westphal wrote:
> > bitmask types default to flagcmp now, thus do not suppress OP_EQ.  Else,
> > 
> > rule filter output tcp flags syn
> > rule filter output tcp flags == syn
> > 
> > are both displayed as 'flags syn'.
> 
> I believe that in other selectors:
> 
>         selector == value
>         selector value
> 
> are equivalent.

Yes, thats true.

> I think it's not just that we have to fix the printing, but make it
> consistent.

Not sure, this was changed recently, see
6bad82aba5d304c7a2dd1b19fe57464dca327f4a
(evaluate: use flagcmp for single RHS bitmask expression).
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux