On Thu, Mar 27, 2014 at 02:47:02PM +0200, Tomasz Bursztyka wrote: > Here is the patch-set to add meta keys NFT_META_BRI_IIFNAME and NFT_META_BRI_OIFNAME. > > I did not factorize nft_meta.c code to reuse nft_meta_select_ops() and nft_meta_bridge_init() > At least solutions I had made the code too ugly. > Declaring a type for select_ops functions, same for validate_get() one, and have > an in-between functions called relevantly by meta_<bridge_>init etc... Thanks. The patches look fine, however I'd ask you to hold off until tommorrow. I have patches coming up that will introduce variable sized registers for concatenations, which remove some of the functions you export, so we can avoid some churn of first exporting, then removing them again by adding your patches on top. Should only be very minor changes to adapt. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
