Re: [PATCH v2 -next] netfilter: nft_ct: labels get support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 18, 2014 at 03:25:32PM +0100, Florian Westphal wrote:
> This also adds NF_CT_LABELS_MAX_SIZE so it can be re-used
> as BUILD_BUG_ON in nft_ct.
> 
> At this time, nft doesn't yet support writing to the label area;
> when this changes the label->words handling needs to be moved
> out of xt_connlabel.c into nf_conntrack_labels.c.
> 
> Also removes a useless run-time check: words cannot grow beyond
> 4 (32 bit) or 2 (64bit) since xt_connlabel enforces a maximum of
> 128 labels.
> 
> Signed-off-by: Florian Westphal <fw@xxxxxxxxx>

Looks very good to me.

Acked-by: Patrick McHardy <kaber@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux