On Tue, Feb 18, 2014 at 10:11:52AM +0100, Arturo Borrero Gonzalez wrote: > On 18 February 2014 02:56, Patrick McHardy <kaber@xxxxxxxxx> wrote: > >> +extern struct set *netlink_delinearize_set(struct netlink_ctx *ctx, > >> + struct nft_set *nls); > > > > Actually delinarization so far refers to the act of converting a linear > > instruction stream into an abstract syntax tree. This is not really a > > good term for sets, which are still pretty much linear. > > > > I don't have a good suggestion right now though. > > At first, I used something like 'nls2set', but this delinearize thing > sounded more 'serious' :) > > In think in all cases, we are converting netlink objects to the > internal nft object. We need a name for that, no? You *could* call it deserialization since we're converting the attribute stream into an object and we should (not done so far) convert bitmask values with more than one bit set into a tree of inclusive OR expressions. Not sure. I guess you can keep that name until we come up with something better, but I wouldn't move it to netlink_delinearize.c. This is meant to mirror netlink_linearize.c, they both only take care of rules. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html