On Mon, Feb 17, 2014 at 04:48:05PM +0100, Florian Westphal wrote: > We segfault on 'list filter' when meta expr is used as _u8 > returns invalid register 0. This seems to only affect the master branch. Not sure how many people are using that and if its worth doing a new release. I'd rather merge the next-3.14 branch and have people use that. On a side note: there's no reason to have our releases timed after kernel releases. At this point I'd rather go for more frequent releases of the current code instead of backporting fixes. > Signed-off-by: Florian Westphal <fw@xxxxxxxxx> > --- > src/netlink_delinearize.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/netlink_delinearize.c b/src/netlink_delinearize.c > index 6668308..b976d86 100644 > --- a/src/netlink_delinearize.c > +++ b/src/netlink_delinearize.c > @@ -346,9 +346,9 @@ static void netlink_parse_meta_sreg(struct netlink_parse_ctx *ctx, > struct expr *expr; > > expr = netlink_get_register(ctx, loc, > - nft_rule_expr_get_u8(nle, NFT_EXPR_META_SREG)); > + nft_rule_expr_get_u32(nle, NFT_EXPR_META_SREG)); > stmt = meta_stmt_alloc(loc, > - nft_rule_expr_get_u8(nle, NFT_EXPR_META_KEY), > + nft_rule_expr_get_u32(nle, NFT_EXPR_META_KEY), > expr); > expr_set_type(expr, stmt->meta.tmpl->dtype, stmt->meta.tmpl->byteorder); > > -- > 1.8.1.5 > > -- > To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
