On Thu, 13 Feb 2014, Florian Westphal wrote:
> Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxxxxxx> wrote:
> >
> > On Wed, 12 Feb 2014, Florian Westphal wrote:
> >
> > > hash:net,iface supports matching on the bridge port as well,
> > > but userspace currently doesn't handle it correctly as it passes
> > > in 'physdev:eth0' instead of 'eth0'+IPSET_OPT_PHYSDEV.
> >
> > I think the userspace does handle the case: looking at your patch, it's
> > exactly the same as the original one. It is nicer, so I'm happy to apply
> > it, but the description - as far as I see - doesn't fit.
>
> It will expand to
>
> if (strcmp("physdev:eth0", "physdev:") == 0)
>
> which is not true.
Ohh, right. And then the whole string is passed to the kernel and
therefore the "physdev:" part is kept at listing.
Patch is applied, thanks!
Best regards,
Jozsef
-
E-mail : kadlec@xxxxxxxxxxxxxxxxx, kadlecsik.jozsef@xxxxxxxxxxxxx
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
H-1525 Budapest 114, POB. 49, Hungary
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
