Hi Giuseppe, On Thu, Feb 06, 2014 at 02:31:10PM +0100, Giuseppe Longo wrote: > Adds nft_arp_save_firewall to arp family. > (Avoids the segfault in xtables-events) > > Signed-off-by: Giuseppe Longo <giuseppelng@xxxxxxxxx> > --- > iptables/nft-arp.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/iptables/nft-arp.c b/iptables/nft-arp.c > index 1710136..bbb168d 100644 > --- a/iptables/nft-arp.c > +++ b/iptables/nft-arp.c > @@ -570,6 +570,14 @@ after_devdst: > fputc('\n', stdout); > } > > +static void nft_arp_save_firewall(const void *data, > + unsigned int format) > +{ > + const struct arpt_entry *fw = data; > + > + return; > +} Please, rework patch 1/3 to make save_firewall option, ie. something like: ... if (ops->save_firewall) ops->save_firewall(data, format); Thus, you don't need this dummy function which is almost noop. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html