Re: [nft RFC PATCH v2] src: add export operation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 21, 2014 at 06:01:54PM +0100, Arturo Borrero Gonzalez wrote:
> This patch adds the following operation:
> 
>  :~# nft export <xml|json>
> 
> The XML/JSON output is provided raw by libnftnl, thus without format.
> 
> In case of XML, you can give format with the `xmllint' tool from libxml2-tools:
>  :~# nft list ruleset xml | xmllint --format -
> 
> In case of JSON, you can use `json_pp' from perl standar package:
>  :~# nft list ruleset json | json_pp
> 
> A format field is added in struct cmd, and it will be reused in the import
> operation.
> 
> Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@xxxxxxxxx>
> ---
> v2: address comments by Patrick: use CMD_OBJ_RULESET, move some includes, etc.

Looks fine to me. I can apply it if you want, not sure since the import
counterpart will have to wait until we have the necessary kernel changes
in place.

Please let me know.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux