Re: [PATCH nft] src: use ':' instead of '=>' in dictionaries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 16, 2014 at 07:25:36PM +0000, Patrick McHardy wrote:
> On Thu, Jan 16, 2014 at 06:37:22PM +0100, Pablo Neira Ayuso wrote:
> > Replace => by : to make it easier for most shell users, as
> > > implies a redirection, let's avoid possible confusion that
> > may result if you forget to escape it.
> > 
> > This works fine if you don't forget to add space between the
> > key and the value. If you forget to add the space, depending
> > on the case, the scanner may recognize it correctly or process
> > it as a string.
> > 
> > Signed-off-by: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
> > ---
> > Tested here with many combinations, works fine if you don't
> > forget the spaces. If you do, the result in unspecified since
> > depending on the combination it may accept it or spot a
> > parsing error.
> 
> Looks good. Please push to master so we can avoid conflicts with
> my patch to make set flags parsable.

Done. Hope it doesn't clash with them.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux