Re: [libnftables PATCH] tests: xml: delete comments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 15 January 2014 14:12, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
> On Wed, Jan 15, 2014 at 12:12:18PM +0100, Arturo Borrero Gonzalez wrote:
>> In libmxml > 2.6, comments are not ignored when building the XML tree,
>> so these comments produce errors and test fail.
>
> Doesn't have libmxml any way to accept comments?

I explained it bad, i'm sorry.

When building a XML tree, only one root node can be in place. This is
a "feature" added in libmxml 2.7:

<<<
mxmlLoad... did not error out on XML with multiple root nodes (Bug #403)
>>>

In libmxml 2.6 the second root node was ingored, not because it was a
comment but because a bug.
Our files had two root nodes, being comments or not.
libmxml accept comments, but inside the root node.

>
>> Delete the comment lines, so parsing test pass with libmxml 2.7 and 2.8.
>>
>> By now, this is the only issue I found when working with libmxml > 2.6.
>
> Kevin mentioned a different error, please investigate it. Thanks.

The error Kevin reported is what I've fixed.

Anyway, I've tested libnftables linked against libmxml 2.7 and 2.8
with no other issues.

-- 
Arturo Borrero González
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux