On Wed, Jan 15, 2014 at 12:09:27PM +0100, Pablo Neira Ayuso wrote:
> This patch adds a special print function for the relational case in
> which == is assumed, so it's not printed. It also fixes the output of
> binary operations from:
>
> & 0x00000003 0x00000001
>
> to:
>
> and 0x00000003 == 0x00000001
>
> diff --git a/src/expression.c b/src/expression.c
> index 6da5c10..452b0d7 100644
> --- a/src/expression.c
> +++ b/src/expression.c
> @@ -411,7 +411,9 @@ static void binop_expr_print(const struct expr *expr)
> printf(" %s ", expr_op_symbols[expr->op]);
> else
> printf(" ");
> +
> expr_print(expr->right);
> + printf(" ==");
That doesn't look right, binops can also occur outside of relational
expressions. I'd suggest to special case OP_EQ and not print it by
default unless the LHS is an EXPR_BINOP.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
