On Monday 2014-01-13 10:12, Patrick McHardy wrote:
>
>> build: remove unused checks
>
>Why aren't we instead evaluating the results?
I don't know - I did not write those lines in the first place. A
reasonable hypothesis is that this is just old boilerplate copied
from somewhere else rather than actually looking for what the
commands executed by make really need.
Furthermore, like a lot of NF software, it is tied to Linux where the
existence of arpa/inet.h, fcntl.h, malloc(3), and so on is
pretty much guaranteed.
The only point to check for absence of stdint.h is when at the same
time, the code provides alternative ways to get what it needs (like a
hand-crafted typedef unsigned char uint8_t) - which are not present
either. So checking for stdint.h is rather useless.
>> build: rename conflicting parser.h instances
>
>The changelog mentions something about -I but no further explanation about
>why this change is done and the effects.
How so? Commit says:
If -I. is on the command line …
and -I. is on the command line with autoconf (more precisely,
-I${srcdir} -I${builddir} -I${path_to_config_h} is).
… #include <parser.h> becomes (=matches) ./parser.h
instead of ../include/parser.h.
Basically you never ever want to have a header with the same include
path. Even #include <regex.h> is prone to ambiguity if you had
-I/usr/include/boost (which you should not of course, but people
do all kinds of weird things sometimes), suddenly matching
/usr/include/boost/regex.h instead of /usr/include/regex.h.
It's all about distributions, and it takes a regular packager to know.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
