On Sun, Jan 12, 2014 at 10:47:01PM +0100, Arturo Borrero Gonzalez wrote: > On 12 January 2014 22:24, Patrick McHardy <kaber@xxxxxxxxx> wrote: > > > > IPv6 addresses are recognized by the parser, so it should be fine. I just > > compile tested this patch, at least bison doesn't report any errors. > > > > '=:' works also as a visual separator. > > If using ':', in the case of IPv6, we can end with: > 2a00:9ac0:c1ca:27::150:123 > > Bison may detect it wisely, but I don't know where the address > start/ends, don't you? > > Or we can force/require a space in the syntax: > 2a00:9ac0:c1ca:27::150 : 123 > > If we decide to use ':', this last case is better, IMHO. We don't need to enforce this IMO. Any reasonable user will most likely add the space himself. If not, no problem, as long as there is no ambiguity. > If you don't like '=:', what about: > '--' > '-:' > '---' > '--:' > or > ':--' Neither of. Too long, and for a mapping ':' or '=>' seem a reasonable choice. ':=' is more like an assignment, which doesn't fit too well. I'd say go for ':', if the user doesn't insert spaces and can't read his own rules anymore, his fault. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
