On Fri, Jan 10, 2014 at 02:48:13PM -0500, David Miller wrote: > From: Patrick McHardy <kaber@xxxxxxxxx> > Date: Fri, 10 Jan 2014 19:42:36 +0000 > > > I can see you're looking out for the important stuff. I consistently > > used this style in nftables so I'm not going to change it here. > > Patrick, please follow the coding style conventions of the kernel, > these issues are important for long term sanity of the kernel tree. > > It helps people who are looking at the netfilter code who perhaps > do not do so usually. Do you really want to use a different style > and therefore make your code harder to read for them? Really? > > Your code being consistent with your code only is less important than > all of the networking looking the same. > > Thank you. I agree to this, in fact style divergences really bother me since they divert my attention :) I considered consistency more important for minor stuff like this, but I really don't mind to add extra braces. But I guess we both agree that its not worth sending patches just to change this but just fix this up next time that line is touched. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
