From: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> Date: Fri, 10 Jan 2014 23:33:22 +0300 > Hello. > > On 01/10/2014 03:35 AM, Pablo Neira Ayuso wrote: > >> net/netfilter/nft_reject.c: In function 'nft_reject_eval': >> net/netfilter/nft_reject.c:37:14: warning: unused variable 'net' >> [-Wunused-variable] > >> Reported-by: kbuild test robot <fengguang.wu@xxxxxxxxx> >> Signed-off-by: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> >> --- >> net/netfilter/nft_reject.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> diff --git a/net/netfilter/nft_reject.c b/net/netfilter/nft_reject.c >> index 0d690d4..7ae63cd 100644 >> --- a/net/netfilter/nft_reject.c >> +++ b/net/netfilter/nft_reject.c >> @@ -34,8 +34,9 @@ static void nft_reject_eval(const struct nft_expr >> *expr, >> const struct nft_pktinfo *pkt) >> { >> struct nft_reject *priv = nft_expr_priv(expr); >> +#if IS_ENABLED(CONFIG_NF_TABLES_IPV6) >> struct net *net = dev_net((pkt->in != NULL) ? pkt->in : pkt->out); >> - > > Why remove empty line after the declaration block? Because "#endif" sort of serves the same purpose. This is what I do too in this situation. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html