On Fri, Jan 10, 2014 at 02:10:25PM +0100, Kristian Evensen wrote: > #define NFTA_CT_MAX (__NFTA_CT_MAX - 1) > diff --git a/src/expr/ct.c b/src/expr/ct.c > index 46e3cef..02a073e 100644 > --- a/src/expr/ct.c > +++ b/src/expr/ct.c > @@ -24,7 +24,8 @@ > > struct nft_expr_ct { > enum nft_ct_keys key; > - uint32_t dreg; /* enum nft_registers */ > + enum nft_registers dreg; > + enum nft_registers sreg; > uint8_t dir; > }; nftables uses statements for things that don't return a value. I think it would make sense to keep this consistent. An "set" expression (aka statement) can never be used in a match, so its something fundamentally different than an expression. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html