Re: [libnftables PATCH next-3.14] expr: fix registers datatypes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 10, 2014 at 01:07:51PM +0100, Arturo Borrero Gonzalez wrote:
> Registers datatypes must be enum nft_registers.
> 
> Pablo Neira says:
> << From the kernel representation point of view, it doesn't make any
> sense to have set both sreg and dreg, but we should not make such
> assumption from userspace. If the user sets both sreg and dreg, it's
> wrong and the kernel should reply -EINVAL so the user knows that it
> has to fix its userspace code. This requires a bit more memory in
> userspace, but we don't have the memory restrictions that we have in
> kernelspace, so a bit more consumption won't harm. >>
> 
> So, while at it, delete the meta expr union for registers.

Need a fix for this in master, I forgot to specify. I just sent several
patches. Thanks anyway.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux