On Fri, Jan 10, 2014 at 09:26:12AM +0100, Kristian Evensen wrote: > Hi Pablo, > > On Fri, Jan 10, 2014 at 1:50 AM, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote: > > Please, rework this. It would be good to rework the meta/set part > > available in libnftables next-3.14. If you cannot make it, let me know > > and I'll schedule time to fix that. Thanks. > > Thank you for your feedback, I will try to rework the patch today and > if not, then over the weekend. > > Btw, during development I noticed that the dreg in ct (in libnftables) > is store as a uint32, while meta uses a uint8 for dreg/sreg. I use a > uint32 for sreg to be consistent with what is already there, but after > looking more into the code this seems not be needed as kernel > sreg/dreg is only 8 bits wide. Should I change the storage type for > sreg/dreg at the same time, or does it qualify as obscure behavior > too? That's inconsistent and needs to be fixed. My suggestion is to fix it by using u32 for registers. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
